Updated Install/Uninstall scripts to resolve #120 #123
Conversation
There was a problem hiding this comment.
After I saw a lot of recent activity on this project I had a look and saw you requested my review on this PR! (Either by accident or intentionally)
Sorry I've been a bit quiet but I have been busy with other things. I'll keep checking back from time to time and see if I can contribute again at some point.
Great to see things moving!
installers/common.sh
Outdated
| @@ -155,7 +160,24 @@ function default_configuration() { | |||
| sudo mv $webroot_dir/config/hostapd.conf /etc/hostapd/hostapd.conf || install_error "Unable to move hostapd configuration file" | |||
| sudo mv $webroot_dir/config/dnsmasq.conf /etc/dnsmasq.conf || install_error "Unable to move dnsmasq configuration file" | |||
| sudo mv $webroot_dir/config/dhcpcd.conf /etc/dhcpcd.conf || install_error "Unable to move dhcpcd configuration file" | |||
| sudo mv $webroot_dir/config/rc.local /etc/rc.local || install_error "Unable to move rc.local file" | |||
| #sudo mv $webroot_dir/config/rc.local /etc/rc.local || install_error "Unable to move rc.local file" | |||
There was a problem hiding this comment.
Can the file config/rc.local be deleted from the repository?
Also, delete this line, rather than leave it commented out, if it is not needed any more.
There was a problem hiding this comment.
I requested it intentionally :) I haven't had much involvement in this apart from creating it initially until now so wanted your input on this :)
Yes, we can delete the config file. I was meant to delete that line as well before I committed it. Oops haha.
|
Also, while you are changing the install script you might check the packages that are installed by apt. I'm not entirely sure but I think |
|
Yes, there seems to be a non-version-specific package for Stretch. Not sure about Jessie though. |
|
Regarding the version of php-cgi (not php-cli as I wrote above), I have created a separate PR for discussion - #124 |
|
I'll remove the rc.local configuration file and remove the commented out lines in the install script then, and merge the changes. |
Issue #120 is regarding our install scripts overwriting the user's rc.local file.
I've updated the install and uninstall scripts now to rectify this issue.
Installing will now append to the rc.local file, rather than moving our own one over the user's one.
A backup is also made before which wasn't happening previously.
The uninstall script has the option to either restore a backup or remove the lines added by our install script.
Also fixed a missing 'read answer' statement, and fixed up some styling for the Web console.