Use sed instead of grep+cut to capture the passphrase #1680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current method would crop any passphrase containing an
=
sign.For eg. with this
hostapd.conf
:the
wpa_passphrase()
function would would returnFoo
instead ofFoo=Bar
, incorrectly cropping thepasskey.
As a result, when editing the hotspot settings, the user may incorrectly update its passkey without even knowing it.
Luckily, mine was cropped to a too short string, so I noticed the error in the form.
I tested the new command with macOS & Linux (Debian) so I guess it should work with most Unix OS.
Also, I guess the problem can happen in other places, like maybe with the
ssid
(can it contain=
signs?).