Skip to content

Fix usage of jsdom/jsdom-global in plugin tests #2528

@BenHenning

Description

@BenHenning

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

All plugins.

Problem

#2525 was needed due to a specific set of circumstances:

Request

The main issue here is that jsdom-global is unlikely to be updated to include SVGElement, and jsdom's best practices (https://github.com/jsdom/jsdom/wiki/Don't-stuff-jsdom-globals-onto-the-Node-global) suggests that we shouldn't be using it, anyway. I'm not certain on the alternative aside from prefixing window and other top-level components on all DOM references (which is likely not tenable for us).

This issue is requesting that we look into alternatives is jsdom provides to not be viable without jsdom-global. Most likely we should consider migrating the Node.js tests over to webdriver, but there may well be other options possible here.

Alternatives considered

The alternative is that we continue to work around the SVG issue and others that come up in the future.

Additional context

This may help with #2527 if the decision is to move toward webdriver tests in genreal.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions