-
Notifications
You must be signed in to change notification settings - Fork 661
Description
Check for duplicates
- I have searched for similar issues before opening a new one.
Component
All plugins.
Problem
#2525 was needed due to a specific set of circumstances:
jsdomupdated to introduce sufficientSVGElementsupport for our testing (I think technically it's had this for a number of years, but there was recent work that made it better). See: ImplementSVGGElementjsdom/jsdom#2734.jsdom-globaldoesn't supportSVGElement, and it seems unlikely to given the lack of updates: Add support for SVGElement? rstacruz/jsdom-global#60.
Request
The main issue here is that jsdom-global is unlikely to be updated to include SVGElement, and jsdom's best practices (https://github.com/jsdom/jsdom/wiki/Don't-stuff-jsdom-globals-onto-the-Node-global) suggests that we shouldn't be using it, anyway. I'm not certain on the alternative aside from prefixing window and other top-level components on all DOM references (which is likely not tenable for us).
This issue is requesting that we look into alternatives is jsdom provides to not be viable without jsdom-global. Most likely we should consider migrating the Node.js tests over to webdriver, but there may well be other options possible here.
Alternatives considered
The alternative is that we continue to work around the SVG issue and others that come up in the future.
Additional context
This may help with #2527 if the decision is to move toward webdriver tests in genreal.