release: update dev-tools to major version and update all plugin dependencies on it #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#1191 was merged but lerna did not correctly pick this up as a major version bump. This is either because
a) Something went wrong because this PR was actually after reverting an identical early PR that wasn't marked as breaking change, so we confused lerna
b) Lerna is looking at the individual commits in the PR (none of which is marked breaking) rather than the squashed commit title (which is marked breaking)
Which of these two scenarios it is needs further testing but regardless, samples is currently borked until this PR sorting things out.
This PR
lerna versionbut with enough command line arguments that it didn't push and tag them automatically, so that's why I say "manually"Details
All the plugins already relied on blockly@8 in dev-dependencies, which is required now to use this version of dev-tools, except for
field-bitmapso I updated that plugin's versions and manually tested, everything looks good.Next steps
from-gitcommand so that lerna doesn't bump them againdev-createto use the new version of dev-tools. I wanted to do that in a separate publish cycle in case this one doesn't work for some reason, then we don't have inaccurate templates.