Skip to content

chore: fix tsconfig path in sample app#1938

Closed
BeksOmega wants to merge 1 commit intoRaspberryPiFoundation:masterfrom
BeksOmega:fix/tsconfig-path-sample
Closed

chore: fix tsconfig path in sample app#1938
BeksOmega wants to merge 1 commit intoRaspberryPiFoundation:masterfrom
BeksOmega:fix/tsconfig-path-sample

Conversation

@BeksOmega
Copy link
Contributor

@BeksOmega BeksOmega commented Sep 19, 2023

The basics

The details

Resolves

Follow up to #1935
Fixes #1934

Proposed Changes

Adds a paths declaration to the sample app.

Reason for Changes

Generate a correct tsconfig automatically.

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner September 19, 2023 13:58
@BeksOmega BeksOmega requested review from NeilFraser and removed request for a team September 19, 2023 13:58
@BeksOmega
Copy link
Contributor Author

BeksOmega commented Sep 19, 2023

@maribethb is this supposed to be added to the sample app? I'm assuming no because other folks might be using hoisting and this would break them, but want to check.

I thought you mentioned something about it yesterday, but now I'm thinking you probably just meant the templates under dev tools.

@BeksOmega BeksOmega force-pushed the fix/tsconfig-path-sample branch from c615f9a to d7d199f Compare September 19, 2023 14:09
@maribethb
Copy link
Contributor

@maribethb is this supposed to be added to the sample app? I'm assuming no because other folks might be using hoisting and this would break them, but want to check.

I thought you mentioned something about it yesterday, but now I'm thinking you probably just meant the templates under dev tools.

This doesn't need to be done for the sample app. This is needed for the plugins in the monorepo, but the sample-app is designed to work outside the monorepo structure. I was only referring to the plugin templates.

@BeksOmega BeksOmega closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Blockly versions / dev tools version conflicts

3 participants