Skip to content

Conversation

@sdthaker
Copy link
Contributor

@sdthaker sdthaker commented Nov 6, 2023

The basics

The details

Resolves

Fixes #1977

Proposed Changes

Added a Github action to build.yml file which essentially runs on the latest ubuntu and checks for code formatting automatically when a new PR is raised. It sets node to v20, installs all dependencies for the project and runs the command npm run format:check which in turn runs prettier --check . to check for code formatting for all the files in the project.

Reason for Changes

Test Coverage

Documentation

Additional Information

@sdthaker sdthaker requested a review from a team as a code owner November 6, 2023 02:01
@sdthaker sdthaker requested review from cpcallen and removed request for a team November 6, 2023 02:01
@google-cla
Copy link

google-cla bot commented Nov 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sdthaker sdthaker changed the title added new gh action to check for formatting upon every pr chore: added new gh action to check for formatting upon every pr Nov 6, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@sdthaker sdthaker force-pushed the Add-a-GitHub-Action-that-runs-the-formatter-#1977 branch from 106edb6 to f63a4d8 Compare November 6, 2023 02:10
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Nov 6, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen November 6, 2023 16:17
@BeksOmega
Copy link
Contributor

@sdthaker Could you rebase this onto the latest master? We had an issue where our package locks got out of sync for a few private packages, but I think it should be resolved if you rebase.

@sdthaker
Copy link
Contributor Author

sdthaker commented Nov 7, 2023

@sdthaker Could you rebase this onto the latest master? We had an issue where our package locks got out of sync for a few private packages, but I think it should be resolved if you rebase.

Sure! I’ll do that in a few of hours! Thanks!

@sdthaker sdthaker force-pushed the Add-a-GitHub-Action-that-runs-the-formatter-#1977 branch from f63a4d8 to a57af58 Compare November 7, 2023 18:01
@sdthaker
Copy link
Contributor Author

sdthaker commented Nov 7, 2023

Please let me know it this works, I rebased the branch against the master branch!

@BeksOmega
Copy link
Contributor

Haha looks like this is good except for the formatting @sdthaker ! Can you run the formatter and then I'll get this merged?

@sdthaker
Copy link
Contributor Author

sdthaker commented Nov 7, 2023

Haha looks like this is good except for the formatting @sdthaker ! Can you run the formatter and then I'll get this merged?

Done! =)

Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you so much for the fix and the back and forth :D

@BeksOmega BeksOmega merged commit 2124f47 into RaspberryPiFoundation:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a GitHub Action that runs the formatter

3 participants