-
Notifications
You must be signed in to change notification settings - Fork 661
chore: added new gh action to check for formatting upon every pr #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added new gh action to check for formatting upon every pr #2060
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
106edb6 to
f63a4d8
Compare
|
@sdthaker Could you rebase this onto the latest master? We had an issue where our package locks got out of sync for a few private packages, but I think it should be resolved if you rebase. |
Sure! I’ll do that in a few of hours! Thanks! |
f63a4d8 to
a57af58
Compare
|
Please let me know it this works, I rebased the branch against the master branch! |
|
Haha looks like this is good except for the formatting @sdthaker ! Can you run the formatter and then I'll get this merged? |
Done! =) |
BeksOmega
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you so much for the fix and the back and forth :D
The basics
The details
Resolves
Fixes #1977
Proposed Changes
Added a Github action to
build.ymlfile which essentially runs on the latest ubuntu and checks for code formatting automatically when a new PR is raised. It sets node to v20, installs all dependencies for the project and runs the commandnpm run format:checkwhich in turn runsprettier --check .to check for code formatting for all the files in the project.Reason for Changes
Test Coverage
Documentation
Additional Information