fix: build for the v11 branch #2268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
Mar 22, 2024
| const chai = require('chai'); | ||
| const {testHelpers} = require('@blockly/dev-tools'); | ||
| const Blockly = require('blockly/node'); | ||
| const Blockly = require('blockly/core'); |
Contributor
There was a problem hiding this comment.
Huh. This should have been done in #2229 and I'm surprised that not doing so didn't fail that build. You can probably just change it to 'blockly' and not add the rest of the lines importing blocks and en separately.
Contributor
Author
There was a problem hiding this comment.
That didn't fail because all of the plugins were still using a version of Blockly that didn't have the exports. Christopher was just linking every plugin locally instead of testing against a beta. In the future, I don't think we should test that way. It's too error prone (e.g. this + he lost a week of work to linking incorrectly).
I'm going to continue importing each thing individually, since that's how we recommend people load the code.
maribethb
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random broken things, some of which were caused by the merge from master into v11, others of which were caused by bumping to the 11.0.0-beta.6