Skip to content

chore: allow const variables to have UPPER_CASE names #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rachel-fenichel merged 1 commit into from
Apr 2, 2024
Merged

chore: allow const variables to have UPPER_CASE names #2300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,11 @@ module.exports = [
match: false,
},
},
{
selector: 'variable',
modifiers: ['const'],
format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
},
],
'@typescript-eslint/consistent-type-assertions': 'error',

Expand Down
1 change: 0 additions & 1 deletion plugins/block-dynamic-connection/src/dynamic_if.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ interface IfExtraState {
hasElse?: boolean;
}

/* eslint-disable @typescript-eslint/naming-convention */
const DYNAMIC_IF_MIXIN = {
/**
* Minimum number of inputs for this block.
Expand Down
2 changes: 0 additions & 2 deletions plugins/block-dynamic-connection/src/dynamic_list_create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ interface DynamicListCreateMixin extends DynamicListCreateMixinType {}
/* eslint-enable @typescript-eslint/no-empty-interface */
type DynamicListCreateMixinType = typeof DYNAMIC_LIST_CREATE_MIXIN;

/* eslint-disable @typescript-eslint/naming-convention */
const DYNAMIC_LIST_CREATE_MIXIN = {
/* eslint-enable @typescript-eslint/naming-convention */
/** Minimum number of inputs for this block. */
minInputs: 2,

Expand Down
2 changes: 0 additions & 2 deletions plugins/block-dynamic-connection/src/dynamic_text_join.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ interface DynamicTextJoinMixin extends DynamicTextJoinMixinType {}
/* eslint-enable @typescript-eslint/no-empty-interface */
type DynamicTextJoinMixinType = typeof DYNAMIC_TEXT_JOIN_MIXIN;

/* eslint-disable @typescript-eslint/naming-convention */
const DYNAMIC_TEXT_JOIN_MIXIN = {
/* eslint-enable @typescript-eslint/naming-convention */
/** Minimum number of inputs for this block. */
minInputs: 2,

Expand Down