fix: remove code of removed colour toolbox#2308
fix: remove code of removed colour toolbox#2308maribethb merged 2 commits intoRaspberryPiFoundation:masterfrom
Conversation
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
I don't think this demo is using Blockly quite correctly, but it's fine to merge this to unblock other work.
| toolboxJson['contents'][4].name = getMsg('Lists'); | ||
| toolboxJson['contents'][5].name = getMsg('Colour'); | ||
| // Separator. | ||
| toolboxJson['contents'][7].name = getMsg('Variables'); |
There was a problem hiding this comment.
@maribethb do you know why we're doing this instead of using Blockly's normal localization?
There was a problem hiding this comment.
Toolboxes don't really have support for dynamic messages afaik. I could see a couple different ways of solving this but I'm not sure which method you're referring to as "normal."
If you want history though, you might have to check with Neil. This is the old demo that's been on devsite for forever and I'm not sure where it came from before we moved it to samples.
There was a problem hiding this comment.
They support replacing message references in category names. Although I guess we don't document this anywhere?
@NeilFraser do you have context for this?
There was a problem hiding this comment.
TIL, I thought you had to do this manually. I thought one of the old demos was doing something similar but I can't find it.
| #blockly-8 { | ||
| #blockly-7 { | ||
| border-left: 15px solid #d7ccc8 !important; | ||
| } |
There was a problem hiding this comment.
I don't think these CSS IDs are technically supported. We should be using a custom toolbox, or category CSS.
There was a problem hiding this comment.
I tried using category css and it works.
Should I update on this PR or open another one when this is done?
There was a problem hiding this comment.
You can make updates on this PR! Thanks for testing that out :D
There was a problem hiding this comment.
Hey @mobyw since this fixes the issue with the live demo we'll actually go ahead and merge it now so we can make sure the demo is running. If you're still up for fixing the css to use the category CSS, that would be great and we'd love a follow up PR! Thanks!
* fix: devsite init script * fix: devsite style
3 participants
The basics
The details
Resolves
Fixes error loading caused by applying changes in #2294.
Proposed Changes
Remove JavasSript and CSS codes of the removed colour toolbox.