fix: Update index.js DOM text reinterpreted as HTML#2329
Merged
NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom Apr 19, 2024
Merged
fix: Update index.js DOM text reinterpreted as HTML#2329NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom
NeilFraser merged 2 commits intoRaspberryPiFoundation:masterfrom
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Contributor
Author
|
Hi @NeilFraser Could You Please Review this PR |
Contributor
|
Google bans use of assignment to innerHTML - with the exception of the empty string. That said, there's no harm in changing this. However, textContent is vastly preferred over innerText: https://kellegous.com/j/2013/02/27/innertext-vs-textcontent/ |
Contributor
Author
|
Hi @NeilFraser Thanks for Reviewing Regards |
NeilFraser
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.