fix(block-test): Fix incorrect references to Blockly.prompt#2344
Merged
fix(block-test): Fix incorrect references to Blockly.prompt#2344
Conversation
This is now Blockly.dialog.prompt, and has been since 7.20211209.0.
7 tasks
maribethb
approved these changes
May 9, 2024
1 task
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Use
Blockly.dialog.promptinstead ofBlockly.prompt.Reason for Changes
This function was moved in v7.20211209.0. Apparently these files were never updated. This change unbreaks the relevant functionality and reduces the number of webpack build warnings for this and several other plugins.