-
Notifications
You must be signed in to change notification settings - Fork 661
feat!: cross-tab-copy-paste can copy more than just blocks #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failures are with shadow-block-converter I guess as a result of updating to v12.1, so I'm going to fix that in a separate PR. Doesn't block review of this one :) |
gonfunko
approved these changes
Jun 27, 2025
Contributor
Author
|
note to self: remove formatting changes to colour-slider so it doesn't get a breaking change |
Contributor
Author
|
Tests should pass after #2574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2565
Fixes #2562
Proposed Changes
Basically rewrote the plugin, perhaps easier to review this commit-wise.
ICopyableitems to be copied, not just blocks.Blockly.Msgvalues for clipboard shortcuts that now exist in core instead of hardcoded strings.keyCodesproperty instead of manually callingaddKeyMappingReason for Changes
Makes this plugin compatible with keyboard-navigation.
Test Coverage
Manual testing only because samples is not set up to use webdriver tests :(
Documentation
readme still looks good
Additional Information