Skip to content

Conversation

@maribethb
Copy link
Contributor

The basics

The details

Resolves

Fixes #2565
Fixes #2562

Proposed Changes

Basically rewrote the plugin, perhaps easier to review this commit-wise.

  • Converted plugin to typescript
  • updated minimum version of Blockly to v12.1.0 because we need a new function only in that release
  • updates all of the logic to be more similar to the logic in core, though with some bug fixes/improvements that were already in the plugin. notably, checks the type counts are allowed for blocks and handles event grouping. this work also enables workspace comments or other ICopyable items to be copied, not just blocks.
  • allow customizing the local storage key
  • use the Blockly.Msg values for clipboard shortcuts that now exist in core instead of hardcoded strings
  • register the keys for shortcuts using .keyCodes property instead of manually calling addKeyMapping
  • add workspace comments to the test page for easier testing.

Reason for Changes

Makes this plugin compatible with keyboard-navigation.

Test Coverage

Manual testing only because samples is not set up to use webdriver tests :(

Documentation

readme still looks good

Additional Information

@maribethb maribethb requested a review from a team as a code owner June 25, 2025 17:14
@maribethb maribethb requested review from gonfunko and removed request for a team June 25, 2025 17:14
@maribethb
Copy link
Contributor Author

The test failures are with shadow-block-converter I guess as a result of updating to v12.1, so I'm going to fix that in a separate PR. Doesn't block review of this one :)

@maribethb
Copy link
Contributor Author

note to self: remove formatting changes to colour-slider so it doesn't get a breaking change

@maribethb
Copy link
Contributor Author

Tests should pass after #2574

@maribethb maribethb merged commit 3fda886 into RaspberryPiFoundation:master Jun 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Gesture checks from shortcut preconditions cross-tab-copy-paste needs keyCodes

2 participants