Skip to content

Conversation

@moniika
Copy link
Contributor

@moniika moniika commented May 5, 2021

  • Fix bug in vertical positioning of zoom-to-fit control that incorrectly added scrollbar thickness for minTop value.
  • Remove clamp of vertical positioning (inconsistent with behavior on master
  • Rename variables and reword comments for readability
  • Refactor for readability

Additional context: Bug in positioning found when working on RaspberryPiFoundation/blockly#4807

Tested manually by changing toolbox positioning of test file and seeing that the zoom-to-fit control was positioned correctly.

@moniika moniika requested a review from maribethb May 5, 2021 22:26
@moniika moniika merged commit b2be0c3 into RaspberryPiFoundation:master May 7, 2021
@moniika moniika deleted the fix-zoom-to-fit-position branch July 1, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants