Skip to content

Conversation

@moniika
Copy link
Contributor

@moniika moniika commented Jun 8, 2021

Removes monkeypatch from Backpack.

Behavior change for darkening ui butting (using new api features):

  • Uses new onMouseOver method that checks if the draggable entering is a Block (and does not darken if a comment is dragged over)
  • Adds mouse event handlers for enter/exit
  • Removes css styling for on-hover so that there is more control over when the backpack darkens

After this PR, the backpack branch can be merged into the release branch.

@moniika moniika marked this pull request as draft June 10, 2021 03:06
@moniika moniika force-pushed the remove-monkeypatch branch 2 times, most recently from 1dbfb7a to cd1e4bb Compare June 11, 2021 01:32
@moniika moniika requested a review from alschmiedt June 11, 2021 01:33
@moniika moniika requested review from rachel-fenichel and removed request for alschmiedt June 11, 2021 18:05
@moniika moniika removed the request for review from rachel-fenichel June 11, 2021 18:11
@moniika moniika force-pushed the remove-monkeypatch branch from 2fcb040 to 17c5057 Compare June 11, 2021 23:58
@moniika moniika requested a review from rachel-fenichel June 11, 2021 23:59
@moniika moniika marked this pull request as ready for review June 12, 2021 00:01
@moniika moniika merged commit 410a158 into RaspberryPiFoundation:backpack Jun 14, 2021
@moniika moniika deleted the remove-monkeypatch branch June 14, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants