fix: Change how dev-tools adds Blockly to the global scope for console debugging #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this reached into
Blockly.utils.globalto make sure that it was getting the same global object as the rest of Blockly.After this change the code uses globalThis. It won't work in IE, but much of dev-tools and our mocha/sinon test setup does not work in IE.
We add
Blocklyto the global object to simplify manual debugging from the console while using dev-tools. It's not necessary for automated tests.Tested by building and starting the dev-tools package locally and inspecting the value of
Blocklyin the console. Also tested by removing the line entirely to make sure thatBlocklywas not being added to the global scope somewhere else.