PHP generator test failure: Lists

[rachel-fenichel]

Error message: syntax error, unexpected ';', expecting :: (T_PAAMAYIM_NEKUDOTAYIM)

[TonyLianLong]

The generator writes code like this:

$list2 = array('Picard', 'Riker', 'Crusher');
  (true ? $list2 : null)[0] = 'Jean-Luc';
  assertEquals($list2, array('Jean-Luc', 'Riker', 'Crusher'), 'set first order list');

which would not work in PHP thus requiring modification.

[AnmAtAnm]

I don't see an obvious solution to this, because I don't see a way to coerce an arbitrary expression into a reference variable in PHP.

When the LIST input is anything but a variables_get block, cacheList() generates this syntactically bad code. Thankfully, this RANDOM case is the only call to cacheList().

function test_set_random_with_syntax_error() {
  global $test_name, $number_of_calls, $list2, $changing_list, $list_copy, $text, $unittestResults;
  $list2 = array('Picard', 'Riker', 'Crusher');
  $tmp_list = &(true ? $list2 : null);                        // Error occurs here.
  $tmp_x = rand(0, count($tmp_list)-1);
  $tmp_list[$tmp_x] = 'Data';
  assertEquals(length($list2), 3, 'set random order list');
}

However, we can pass the ternary into a helper function to perform the set, we get a much clearer message "Only variables can be passed by reference":

function set_random_helper(&$tmp_list) {
  $tmp_x = rand(0, count($tmp_list)-1);
  $tmp_list[$tmp_x] = 'Data';
}

function test_set_random() {
  global $test_name, $number_of_calls, $list2, $changing_list, $list_copy, $text, $unittestResults;
  $list2 = array('Picard', 'Riker', 'Crusher');
  set_random_helper(true ? $list2 : null);
  assertEquals(length($list2), 3, 'set random order list');
}

For future reference, I used the following blocks to run these tests:

<xml xmlns="http://www.w3.org/1999/xhtml">
  <variables>
    <variable type="" id="QVk5COPkwSE=8S9aO5:_">test name</variable>
    <variable type="" id="F:4.?_lk%-vUl2Rw1NI2">number of calls</variable>
    <variable type="" id="6;_6wNBQP@WN2?JR/3A-">list</variable>
    <variable type="" id="B$l{x+bgtF.E^,ds0AT=">changing list</variable>
    <variable type="" id="{=8IqFRZOKrF(]oZ7!6U">list copy</variable>
    <variable type="" id="B_B|I;,I;TO^tvmUSr[`">text</variable>
    <variable type="" id="BvSID28;FSb,wr01K|Ei">unittestResults</variable>
  </variables>
  <block type="unittest_main" x="13" y="13">
    <statement name="DO">
      <block type="procedures_callnoreturn">
        <mutation name="just the test with the syntax error"></mutation>
      </block>
    </statement>
  </block>
  <block type="procedures_defnoreturn" x="13" y="112">
    <field name="NAME">just the test with the syntax error</field>
    <comment pinned="false" h="80" w="160">Tests the "set" block.</comment>
    <statement name="STACK">
      <block type="variables_set" inline="false">
        <field name="VAR" id="6;_6wNBQP@WN2?JR/3A-" variabletype="">list</field>
        <value name="VALUE">
          <block type="lists_create_with" inline="true">
            <mutation items="3"></mutation>
            <value name="ADD0">
              <block type="text">
                <field name="TEXT">Picard</field>
              </block>
            </value>
            <value name="ADD1">
              <block type="text">
                <field name="TEXT">Riker</field>
              </block>
            </value>
            <value name="ADD2">
              <block type="text">
                <field name="TEXT">Crusher</field>
              </block>
            </value>
          </block>
        </value>
        <next>
          <block type="lists_setIndex">
            <mutation at="false"></mutation>
            <field name="MODE">SET</field>
            <field name="WHERE">RANDOM</field>
            <value name="LIST">
              <block type="logic_ternary" inline="true">
                <value name="IF">
                  <block type="logic_boolean">
                    <field name="BOOL">TRUE</field>
                  </block>
                </value>
                <value name="THEN">
                  <block type="variables_get">
                    <field name="VAR" id="6;_6wNBQP@WN2?JR/3A-" variabletype="">list</field>
                  </block>
                </value>
                <value name="ELSE">
                  <block type="logic_null"></block>
                </value>
              </block>
            </value>
            <value name="TO">
              <block type="text">
                <field name="TEXT">Data</field>
              </block>
            </value>
            <next>
              <block type="unittest_assertequals" inline="false">
                <value name="MESSAGE">
                  <block type="text">
                    <field name="TEXT">set random order list</field>
                  </block>
                </value>
                <value name="ACTUAL">
                  <block type="lists_length" inline="false">
                    <value name="VALUE">
                      <block type="variables_get">
                        <field name="VAR" id="6;_6wNBQP@WN2?JR/3A-" variabletype="">list</field>
                      </block>
                    </value>
                  </block>
                </value>
                <value name="EXPECTED">
                  <block type="math_number">
                    <field name="NUM">3</field>
                  </block>
                </value>
              </block>
            </next>
          </block>
        </next>
      </block>
    </statement>
  </block>
</xml>

[rachel-fenichel]

Tests in the Lists group that fail due to syntax errors:

test_get_complex()
test_getRemove()
test_remove()
test_set()
test_insert()

[rachel-fenichel]

I don't see that we're going to fix this any time soon. I propose that we add a warning (an alert?) in the generated code to warn that this may not work, or else that we remove the generators for these blocks entirely.