Skip to content

Empty action is added to the undo stack when dragging block directly from the toolbox to trash #1458

@vicng

Description

@vicng

Problem statement

  • Bug report
  • Feature request

If you drag a block directly from the toolbox straight into the trash, this generates an "undo" action. Rewinding this "undo" action does nothing.

Expected Behavior

No "undo" action should be added to the undo/redo stack.

Actual Behavior

All relevant events (create, move, delete) are added to the stack as a group.

Steps to Reproduce

  1. Open the toolbox and add a block to the workspace.
  2. Now, drag another block straight from the toolbox and into the trash.
  3. Undo the action (Ctrl-Z/Cmd-Z) -> Nothing happens (step 1 should be the thing that's undone).

Additional Information

I think the ideal behavior is to remove these events from the event stack, if this scenario is detected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions