Skip to content

Renaming a procedure does not group events #1508

@RoboErikG

Description

@RoboErikG

Problem statement

It looks like we lost a setGroup(true) somewhere in procedure renaming. This is causing each keystroke and each rename of a caller to be a separate undo action.

If you rename a procedure that has callers you will end up with an extra undo op for every block that was renamed. When you use ctrl+z to undo you then have to do an extra undo for each block. They are all renamed on the first undo, so the extra undos are just no-ops.

Expected Behavior

One undo group for all the renames.

Actual Behavior

The events for a procedure name change have no group.

Steps to Reproduce

  1. Create a procedure
  2. Create two callers of the procedure
  3. Change the name of the procedure.
  4. Undo the name change.

Stack Traces

Replace with error stack trace.

Operating System and Browser

Desktop Chrome

Additional Information

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions