Skip to content

Comments blocklyMinimalBody Inherits body Styling #2440

@BeksOmega

Description

@BeksOmega

Problem statement

Comments contain a body element which inherits any styling done to body as a whole. This can cause weird rendering bugs that are hard to track down.

Expected Behavior

Comments should look like this no matter what:
OldRendering

Actual Behavior

Comments inherit styling, here's an example where the body's height is set to calc(100% - 2em), which is how I discovered this. Not sure what other inherited properties might be bad.
Comments_Workspace

Comments_Block

Steps to Reproduce

  1. Open the playground and add height: calc(100% - 2em); to the body style.
  2. Grab a procedure block and open its comment.

Operating System and Browser

  • Desktop Chrome
  • Desktop Firefox
  • Windows Edge

(Comment rendering doesn't work at all on IE)

Additional Information

N/A

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions