-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
internalExternal contributions not acceptedExternal contributions not acceptedlow prioritytype: cleanup
Milestone
Description
Describe the bug
Comments use warnings' UI when displaying in non-editable mode.
This means that comments need to access, and have knowledge of, things that they really shouldn't.
Slightly Prefered Solution
Comments should have their own UI for displaying non-editable mode.
Alternative Solutions
- The UI for both warnings and non-editable comments should be put into a single class so that they're less tightly coupled.
- Comments don't have special UI for non-editable mode. Instead changes to the comment aren't saved.
Additional context
Related: #2917
Metadata
Metadata
Assignees
Labels
internalExternal contributions not acceptedExternal contributions not acceptedlow prioritytype: cleanup