Warning bubbles do not resize on text resize

[BeksOmega]

Describe the bug

If you pass a new text size to the theme the text on a warning bubble will resize but the warning bubble itself will not resize.

To Reproduce

Steps to reproduce the behavior:

1. Load the following xml to the playground.

<xml xmlns="https://developers.google.com/blockly/xml">
  <block type="controls_flow_statements">
    <field name="FLOW">BREAK</field>
  </block>
</xml>

2. Open the warning.
3. Use the text size slider to change the text size.

Expected behavior

The warning bubble should probably update its size automatically.

Here are a few ideas from @samelhusseini from here:

This one's a little tricky as icons don't have render loops.

• We could add render loops, and re-render on a theme change.
• reset visibility for warnings that are open. (ie: set to false, and back to true, which would dispose and recreate the bubble)
• close all warnings when we need to re-render the workspace.

Additional context

N/A

[steviedupree]

Does this still need to be worked on?

[BeksOmega]

Does this still need to be worked on?

Yes this is still an issue :D

If you're interested in working on it (or anyone else is =), I recommend attempting option 2 that Sam provided:

reset visibility for warnings that are open. (ie: set to false, and back to true, which would dispose and recreate the bubble)

While it may not be the most computationally efficient method, it should be simple and effective. And if efficiency becomes a problem, we can always implement a different solution later =) To get started you'll want to check out:

• block_svg.render
• warning.setVisible
• and the bubble "class"

If that solution doesn't work out (for whatever reason) I recommend trying the second option that Sam provided:

close all warnings when we need to re-render the workspace.

In that case you'll want to check out workspace_svg.render.

If you have any questions or need help feel free to ask! Best wishes --Beka