-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
component: testsissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be added
Milestone
Description
Describe the bug
A bug was introduced into core when we removed a folder under core without removing it from the typings script. The travis build did not catch this, and instead reported it was passing.
On top of this there were folders that were not added to this script and so the typings in these folders were not being checked.
To Reproduce
- Add a folder that does not exist into core.
- Open a PR
- Travis does not fail.
Expected behavior
Travis should fail.
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Stack Traces
Additional context
One option for the second part of this bug is to have the script check all child directories of core. This would mean that we wouldn't have to worry about manually adding them whenever we add a new folder.
Metadata
Metadata
Assignees
Labels
component: testsissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be added