-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Description
Describe the bug
The block test toolbox (on the playground) and advanced playground rely on having run npm install in order to load. When opening either of these on apengine hosted demo site, they do not load and emit the alert "You need to run 'npm install' in order to use the test blocks." or "You need to run 'npm install' in order to use this playground.".
To Reproduce
Steps to reproduce the behavior:
Go to either:
- https://blockly-demo.appspot.com/static/tests/playground.html?dir=ltr&toolbox=test-blocks
- https://blockly-demo.appspot.com/static/tests/playgrounds/advanced_playground.html
Expected behavior
The advanced playground should not be uploaded to appengine.
The playground should either not be uploaded to appengine or the test toolbox should not be allowed to be selected from the dropdown of toolboxes (this second option could be tricky and would be best if it only affected appengine hosted instances of the page).
Additional context
We already use github.io for testing on playground and the playgrounds do not seem linked in the index page, so not uploading them to appengine entirely seems like the most straightforward option.