-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
component: toolbox/flyouthelp wantedExternal contributions actively solicitedExternal contributions actively solicitedissue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongsize: smallBugs that can be picked up and completed in 1-3 daysBugs that can be picked up and completed in 1-3 days
Milestone
Description
Describe the bug
If you define a toolbox where the block info has x and y properties, the blocks will be positioned incorrectly.
To Reproduce
Steps to reproduce the behavior:
- Create a toolbox definition.
- Add blocks to it
- Give those blocks x and y properties (That are non-zero)
- Observe how they are positioned incorrectly.
Expected behavior
The toolbox should ignore the x and y properties on blocks because it has its own gap/separator logic for positioning blocks.
Additional context
- The BlockInfo type should be updated to not include X and Y.
- Blockly has two kinds of flyouts built-in, horizontal and vertical. You should update the layout logic in both of them.
- The flyouts should be changed to use moveTo instead of moveBy
Tips for Getting Started
We have a lot of information about how to get started here including details about our commit message style and how to open a PR.
Metadata
Metadata
Assignees
Labels
component: toolbox/flyouthelp wantedExternal contributions actively solicitedExternal contributions actively solicitedissue: bugDescribes why the code or behaviour is wrongDescribes why the code or behaviour is wrongsize: smallBugs that can be picked up and completed in 1-3 daysBugs that can be picked up and completed in 1-3 days