-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Closed
Labels
internalExternal contributions not acceptedExternal contributions not acceptedissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be addedtype: cleanup
Description
Is your feature request related to a problem? Please describe.
The Edge browser used to use the EdgeHTML browser engine, but has not done so since version 79. Our checks for Edge in useragent.js were actually looking for EdgeHTML. It is now fully deprecated, so we can remove these workarounds.
Describe the solution you'd like
- Remove uses of
userAgent.EDGEin Blockly core. - Remove
isEdgeandEDGEfromuseragent.ts - Remove EdgeHTML workarounds from stripped-down
base.jsLeft in to match upstreambase.js
Describe alternatives you've considered
Leave them in. Rejected as extra ongoing maintenance for something that is not used.
Additional context
Inspecting user agent strings is strongly discouraged because they often contain misleading information--for instance, the Edge browser uses the Blink browser engine.
Found while looking into user agent strings for #6336.
Metadata
Metadata
Assignees
Labels
internalExternal contributions not acceptedExternal contributions not acceptedissue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be addedtype: cleanup