Skip to content

Media files corrupted during packaging #8705

@jfedor2

Description

@jfedor2

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

If you look at the files inside the latest release tarball (blockly-11.2.0.tgz), the binaries in the media/ directory are different than the ones in the repository. Looking closer, they have a lot of EF BF BD byte sequences where they shouldn't, which is the UTF-8 representation of Unicode 'REPLACEMENT CHARACTER' (U+FFFD), suggesting that something is interpreting the binaries as Unicode, which obviously isn't right for MP3s etc.

Indeed that's what gulp's src() is doing unless you pass the encoding: false option (it was a breaking change in version 5.0.0).

Reproduction steps

  1. npm run package
  2. diff media/click.mp3 dist/media/click.mp3

Stack trace

Screenshots

No response

Browsers

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue: bugDescribes why the code or behaviour is wrongissue: triageIssues awaiting triage by a Blockly team member

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions