Build system changes cleanup #5018
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also consistently use {recursive: true} in case directory is nested
in an also-not-yet-existent directory.
npm test has been failing if previous build output was present, because the generated build/msg/??.msg files are missing a trailing newline and the line to exclude build/* from being linted was inadvertently omitted from commit 9e72378. (Much of the rest of the build output would also fail lint checks but was already excluded by the *_compressed*.js exclusion.)
3 tasks
rachel-fenichel
requested changes
Jul 13, 2021
scripts/gulpfiles/build_tasks.js
Outdated
| */ | ||
| function buildLangfiles(done) { | ||
| // Create output directory. | ||
| // TODO(#5000): does mkidr -p work on Windows? |
Collaborator
There was a problem hiding this comment.
Remove this comment since you've now checked.
scripts/gulpfiles/appengine_tasks.js
Outdated
| } | ||
| fs.mkdirSync(demoStaticTmpDir, { recursive: true }); | ||
| done() | ||
| fs.mkdir(demoStaticTmpDir, {recursive: true}); |
Collaborator
There was a problem hiding this comment.
Should still be mkdirSync
cpcallen
commented
Jul 13, 2021
An intermediate version of this code read:
fs.mkdir(demoStaticTmpDir, {recursive: true}), done);
but apparently `fs.mkdir` doesn't honour the recursive option, so I
tried to revert the change but munged it instead.
This commit cleans up the mess I made.
rachel-fenichel
approved these changes
Jul 13, 2021
No more `execSync('mkdir -p')` so no more need to check if it works on
Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Behavior Before Change
mkdir -pcommand.npm testwill fail ifnpm run clean(ornpm run clean:build) isn't run first.Behavior After Change