Adds a serializer test suite - project cereal #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
reviewed
Jul 13, 2021
moniika
reviewed
Jul 13, 2021
BeksOmega
commented
Jul 13, 2021
BeksOmega
force-pushed
the
tests/serialier
branch
from
c0736b4 to
b9c167e
Compare
BeksOmega
force-pushed
the
tests/serialier
branch
from
b9c167e to
4f4ac1c
Compare
3 tasks
moniika
suggested changes
Jul 15, 2021
moniika
reviewed
Jul 15, 2021
Contributor
Author
|
@moniika I think that everything's fixed! @maribethb Do you want to take a look before this goes in or does Monica's review cover it? Abby took a look yesterday to stay up-to-date but didn't review. |
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Sep 13, 2021
…5034) * Setup basic architecture for tests * Attribute tests * Easy field tests added * Work on tests * Work on tests * Work on tests * Add mutation tests * Fixup ID tests * Add more mutator tests * Fixup lint and typos * Uncomment tests * Use test helpers * Small PR comments * Use test helpers for setup and teardown * Add TODOs and fixup types * Fix types * Actually fix types
BeksOmega
added a commit
that referenced
this pull request
Sep 17, 2021
* Setup basic architecture for tests * Attribute tests * Easy field tests added * Work on tests * Work on tests * Work on tests * Add mutation tests * Fixup ID tests * Add more mutator tests * Fixup lint and typos * Uncomment tests * Use test helpers * Small PR comments * Use test helpers for setup and teardown * Add TODOs and fixup types * Fix types * Actually fix types
alschmiedt
pushed a commit
to alschmiedt/blockly
that referenced
this pull request
Sep 20, 2021
…5034) * Setup basic architecture for tests * Attribute tests * Easy field tests added * Work on tests * Work on tests * Work on tests * Add mutation tests * Fixup ID tests * Add more mutator tests * Fixup lint and typos * Uncomment tests * Use test helpers * Small PR comments * Use test helpers for setup and teardown * Add TODOs and fixup types * Fix types * Actually fix types
alschmiedt
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Setup basic architecture for tests * Attribute tests * Easy field tests added * Work on tests * Work on tests * Work on tests * Add mutation tests * Fixup ID tests * Add more mutator tests * Fixup lint and typos * Uncomment tests * Use test helpers * Small PR comments * Use test helpers for setup and teardown * Add TODOs and fixup types * Fix types * Actually fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on Project Cereal
Proposed Changes
Adds a suite for testing serializers, as outlined in my design document. Once we're sure that this suite covers enough cases, this will be moved into the dev-tools test helpers.
Currently this just tests that the XML round-trips correctly, but the idea is that you can plug in other serializers (including the JSON serializer).
Reason for Changes
Greatly increases test coverage of the serialization system. This gives us confidence that the new JSON serializer will properly round-trip state. Also once this is a test helper it will make it easy for devs to test their custom serializers.
Documentation
When this moves into the dev-tools package this will need to be added to the readme. But for now no docs are needed.
Additional Information
@moniika you don't need to give this a full review, but I would appreciate your expert eye giving it a quick look to make sure there are no glaring errors =)