Add flag to webdriverio options #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#5030
Proposed Changes
Adds flag to webdriverio options.
Behavior Before Change
Mocha tests fail when any .js files have been converted to
goog.module.Behavior After Change
Mocha tests pass.
Reason for Changes
Failing tests.
Test Coverage
Tested by running
node tests/mocha/run_mocha_tests_in_browser.jsin this branch and on branch of https://github.com/cpcallen/blockly/tree/migrate with the same change.Additional Information
This change should also be merged into the goog_module branch.