Remove themes that were moved to blockly samples #5041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jul 13, 2021
This resolves a conflict in `blockly_uncompressed.js`, and missing updates to `test/deps.js`, caused by PR RaspberryPiFoundation#5041.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #4987
Proposed Changes
Remove themes that have been moved to Blockly Samples.
Behavior Before Change
The following themes were available in core:
Behavior After Change
Developers have to use one of the plugins published on npm to use the theme.
Reason for Changes
These themes fit better as plugins. We did not have plugins architecture in place when they were created.
Test Coverage
Documentation
Additional Information