Add serialization of basic block attributes to JSOs #5053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
BeksOmega
force-pushed
the
cereal/block-serialization
branch
from
51442e1 to
dfce263
Compare
BeksOmega
commented
Jul 15, 2021
| * @param {!Blockly.serialization.blocks.State} state The state object to append | ||
| * to. | ||
| */ | ||
| const addAttributes = function(block, state) { |
Contributor
Author
There was a problem hiding this comment.
Update private functions w/ whatever the preferred syntax is before merging.
BeksOmega
commented
Jul 19, 2021
Comment on lines
80
to
82
| if (!block.isEnabled()) { | ||
| state['disabled'] = true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Do we want to change this to be state['enabled'] to match the new API?
Collaborator
There was a problem hiding this comment.
In general I think 'enabled' flags are easier to understand than 'disabled' ones (and therefore preferable), but given that undefined is falsey there might be an argument to using disabled if 'enabled' is the default state allowing the flat to be omitted in most cases.
BeksOmega
force-pushed
the
cereal/block-serialization
branch
from
dfce263 to
38bb6d8
Compare
maribethb
approved these changes
Jul 23, 2021
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Sep 13, 2021
…ation#5053) * Add basic attribute tests * Add basic block serialization * Add more attribute tests * Change save to use options dictionary * Add obeying save options * Add test for data attribute * Add saving data tag * Move to ES6 syntax * Fixup move to es6 syntax * Declare module * Format and lint * Add docs * Add returning null on insertion markers * Fixup for move to module * Switch to other function declarations * Cleanup for finalized style * Fix lint and types * Export State def * Switch disabled=true to enabled=false
BeksOmega
added a commit
that referenced
this pull request
Sep 17, 2021
* Add basic attribute tests * Add basic block serialization * Add more attribute tests * Change save to use options dictionary * Add obeying save options * Add test for data attribute * Add saving data tag * Move to ES6 syntax * Fixup move to es6 syntax * Declare module * Format and lint * Add docs * Add returning null on insertion markers * Fixup for move to module * Switch to other function declarations * Cleanup for finalized style * Fix lint and types * Export State def * Switch disabled=true to enabled=false
alschmiedt
pushed a commit
to alschmiedt/blockly
that referenced
this pull request
Sep 20, 2021
…ation#5053) * Add basic attribute tests * Add basic block serialization * Add more attribute tests * Change save to use options dictionary * Add obeying save options * Add test for data attribute * Add saving data tag * Move to ES6 syntax * Fixup move to es6 syntax * Declare module * Format and lint * Add docs * Add returning null on insertion markers * Fixup for move to module * Switch to other function declarations * Cleanup for finalized style * Fix lint and types * Export State def * Switch disabled=true to enabled=false
alschmiedt
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Add basic attribute tests * Add basic block serialization * Add more attribute tests * Change save to use options dictionary * Add obeying save options * Add test for data attribute * Add saving data tag * Move to ES6 syntax * Fixup move to es6 syntax * Declare module * Format and lint * Add docs * Add returning null on insertion markers * Fixup for move to module * Switch to other function declarations * Cleanup for finalized style * Fix lint and types * Export State def * Switch disabled=true to enabled=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
Link for Diff: BeksOmega/blockly@cereal/basic-hooks...BeksOmega:cereal/block-serialization
The details
Resolves
Work on project cereal
Dependent on #5052
Proposed Changes
Adds serialization of basic block attributes: type, id, x, y, collapsed, deletable, etc.
Does not serialize children, fields, mutators, or icons. Does not handle deserialization.
Reason for Changes
Serializing state is good.
Test Coverage
Added unit tests to make sure the serializer is returning an object with the structure we expect.