Migrate core/connection.js to goog.module syntax #5102
Conversation
| Blockly.Connection.REASON_DIFFERENT_WORKSPACES = 5; | ||
| Blockly.Connection.REASON_SHADOW_PARENT = 6; | ||
| Blockly.Connection.REASON_DRAG_CHECKS_FAILED = 7; | ||
| Connection.CAN_CONNECT = 0; |
There was a problem hiding this comment.
This looks like an instance of "Exports a class constructor with unrelated static properties", which is one of the triage categories in #5073
Intuitively, I expected that these would be exported directly.
There was a problem hiding this comment.
Yes: not for this PR, but this looks like it should be an enum. In that form I think it is probably closely-related enough that it could be exported either as a static property of Connection (e.g. Connection.Reason) or beside it (e.g., exports = {Connection, ConnectionReason}). Added to list in #5073.
There was a problem hiding this comment.
Is there any action needed here beyond adding to the triage list?
core/connection.js
Outdated
| * @private | ||
| */ | ||
| Blockly.Connection.connectReciprocally_ = function(first, second) { | ||
| Connection.connectReciprocally_ = function(first, second) { |
There was a problem hiding this comment.
Since this one is private and static, I think it can just become a module-internal function named connectReciprocally.
There was a problem hiding this comment.
Same for the next few private static functions.
|
As mentioned in the team meeting, this is one of the files I'm going to be modifying. In this case, to deal with shadows. |
4 participants
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026