feat: add serialization of child blocks #5120
Conversation
BeksOmega
requested review from
alschmiedt and
maribethb
and removed request for
cpcallen
core/serialization/blocks.js
Outdated
| { | ||
| addCoordinates = false, | ||
| addInputBlocks = true, | ||
| addNextBlocks = false |
There was a problem hiding this comment.
It may be better to set this to true by default. Not sure.
There was a problem hiding this comment.
Hmm, what was the original reasoning for defaulting to false here?
My original assumption was that addNextBlocks would be true, but I am not sure I have a great reason for it.
There was a problem hiding this comment.
Originally it was because I thought there were a lot of internal things in Blockly that used this behavior. But it turns out it's just copy paste, and everything else wants next blocks. I'll switch it over to true by default.
alschmiedt
left a comment
alschmiedt
left a comment
There was a problem hiding this comment.
Overall lgtm, I just have some questions about types.
core/serialization/blocks.js
Outdated
| { | ||
| addCoordinates = false, | ||
| addInputBlocks = true, | ||
| addNextBlocks = false |
There was a problem hiding this comment.
Hmm, what was the original reasoning for defaulting to false here?
My original assumption was that addNextBlocks would be true, but I am not sure I have a great reason for it.
BeksOmega
force-pushed
the
cereal/connnected-blocks
branch
from
607d0e8 to
703decb
Compare
BeksOmega
changed the title
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
2 participants
The basics
Link for Diff: BeksOmega/blockly@cereal/field-upgrades...BeksOmega:cereal/connnected-blocks
The details
Resolves
Work on project cereal
Dependent on #5077
Proposed Changes
Adds support for serializing children of a block.
Does not handle deserialization.
Reason for Changes
Saving state is good.
Test Coverage
Added tests for:
saveie do save or don't save.