Skip to content

Update goog.module-migrated files to fix style issues #5148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gonfunko merged 1 commit into from
Jul 22, 2021
Merged

Update goog.module-migrated files to fix style issues #5148

gonfunko merged 1 commit into from
Jul 22, 2021

Conversation

@gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Jul 21, 2021

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • I have run npm test.

The details

Resolves

Part of #5026

Proposed Changes

  • This moves from one exports = {} statement at the end to exporting each individual function.
  • Imports have been sorted alphabetically by Capital, lowercase, {Capital}, {lowercase}, extraRequires.
  • @public/@Private annotations on top-level functions have been removed, and @Package annotations have been moved to the export.
  • Files have been migrated to the const foo = function(){...}; exports.foo = foo; syntax.
  • Requires used only in JSDoc have had the linter disabled.

@gonfunko gonfunko requested a review from a team as a code owner July 21, 2021 17:26
@gonfunko gonfunko requested a review from alschmiedt July 21, 2021 17:26
@gonfunko gonfunko self-assigned this Jul 21, 2021
@github-actions github-actions bot added this to the 2021_q3_release milestone Jul 21, 2021
@gonfunko gonfunko assigned cpcallen and unassigned gonfunko Jul 21, 2021
@gonfunko gonfunko requested a review from cpcallen July 21, 2021 17:27
@cpcallen cpcallen changed the title Update goog.module-migrated files to use inline exports Update goog.module-migrated files to fix style issues Jul 22, 2021
cpcallen
cpcallen approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. I've taken the liberty of tweaking the PR title, as it fixes several style issues not just inlining exports.

@cpcallen cpcallen assigned gonfunko and unassigned cpcallen Jul 22, 2021
@gonfunko gonfunko merged commit 83ff0ea into RaspberryPiFoundation:goog_module Jul 22, 2021
@gonfunko gonfunko deleted the rerefactor branch July 22, 2021 15:09
@cpcallen cpcallen linked an issue Jul 22, 2021 that may be closed by this pull request
Update exports style in goog.module-migrated files #5133
Closed
@cpcallen cpcallen mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcallen cpcallen cpcallen approved these changes

@alschmiedt alschmiedt Awaiting requested review from alschmiedt

Assignees

@gonfunko gonfunko

Labels

type: cleanup

Projects

None yet

Milestone

2021_q3_release

Development

Successfully merging this pull request may close these issues.

Update exports style in goog.module-migrated files

2 participants

@gonfunko @cpcallen