Migrate core/registry.js to goog.module syntax #5217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Jul 27, 2021
core/registry.js
Outdated
| throw Error( | ||
| 'Invalid type "' + type + '". The type must be a' + | ||
| ' non-empty string or a Blockly.registry.Type.'); | ||
| ' non-empty string or a Type.'); |
Contributor
There was a problem hiding this comment.
I think this error message should retain the namespace for legibility.
Contributor
Author
There was a problem hiding this comment.
Good call, updated.
| */ | ||
| this.name_ = name; | ||
| }; | ||
| exports.Type = Type; |
Contributor
There was a problem hiding this comment.
This seems like it may be one of the cases where Type ought to be a class in its own file and moved out of this one, and we should add it to the list of weird files to follow up on. Because this isn't just a static function on the registry namespace like many of the other files have.
Contributor
Author
There was a problem hiding this comment.
Added a note about this to the tracking issue, I agree it seems reasonable to split it out into its own file.
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/registry.jstogoog.modulewith ES6const/let.