Skip to content

Migrate core/options.js to goog.module syntax #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moniika merged 6 commits into from
Aug 5, 2021
Merged

Migrate core/options.js to goog.module syntax #5287

moniika merged 6 commits into from
Aug 5, 2021

Conversation

@moniika
Copy link
Contributor

@moniika moniika commented Aug 2, 2021

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/options.js to goog.module syntax.

Additional Information

This PR also refactors Blockly.BlocklyOptions our of Blockly.Options into a separate module in core/blockly_options.js and adds missing requires to files that use Blockly.BlocklyOptions.
In some cases, unused Blockly requires were removed (under the assumption that they were added by mistake thinking they were needed for Blockly.BlocklyOptions

@moniika moniika requested a review from cpcallen August 2, 2021 20:16
@moniika moniika requested a review from a team as a code owner August 2, 2021 20:16
@github-actions github-actions bot added this to the 2021_q3_release milestone Aug 2, 2021
cpcallen
cpcallen approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits.

@cpcallen cpcallen assigned moniika and unassigned cpcallen Aug 5, 2021
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Aug 5, 2021
@github-actions github-actions bot removed the cla: yes Used by Google's CLA checker. label Aug 5, 2021
@google-cla
Copy link

google-cla bot commented Aug 5, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Aug 5, 2021
@moniika moniika merged commit 569ddec into RaspberryPiFoundation:goog_module Aug 5, 2021
@moniika moniika deleted the convert-options branch August 5, 2021 17:50
@moniika moniika removed their assignment Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees

No one assigned

Labels

cla: yes Used by Google's CLA checker. type: cleanup

Projects

None yet

Milestone

2021_q3_release

Development

Successfully merging this pull request may close these issues.

2 participants

@moniika @cpcallen