Skip to content

Migrate core/events/events.js to goog.module syntax #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 6 commits into from
Aug 26, 2021
Merged

Migrate core/events/events.js to goog.module syntax #5302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f460f3
Migrate core/events/events.js to ES6 const/let
gonfunko Aug 2, 2021
80ec4d4
Migrate core/events/events.js to goog.module
gonfunko Aug 3, 2021
bfd9f1f
Migrate core/events/events.js to named requires
gonfunko Aug 4, 2021
1c9362d
clang-format core/events/events.js
gonfunko Aug 4, 2021
1ee7b59
Migrate Blockly core to use getRecordUndo/setRecordUndo
gonfunko Aug 12, 2021
f3910e3
Update core/events.js to reflect latest guidance around exporting mut…
gonfunko Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,14 +224,14 @@ const Block = function(workspace, prototypeName, opt_id) {
if (!existingGroup) {
Events.setGroup(true);
}
const initialUndoFlag = Events.recordUndo;
const initialUndoFlag = Events.getRecordUndo();

try {
// Call an initialization function, if it exists.
if (typeof this.init == 'function') {
Events.recordUndo = false;
Events.setRecordUndo(false);
this.init();
Events.recordUndo = initialUndoFlag;
Events.setRecordUndo(initialUndoFlag);
}

// Fire a create event.
Expand All @@ -244,7 +244,7 @@ const Block = function(workspace, prototypeName, opt_id) {
Events.setGroup(false);
}
// In case init threw, recordUndo flag should still be reset.
Events.recordUndo = initialUndoFlag;
Events.setRecordUndo(initialUndoFlag);
}

// Record initial inline state.
Expand Down
Loading