-
Notifications
You must be signed in to change notification settings - Fork 3.8k
cleanup: Change type defs for state types to records #5313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BeksOmega
wants to merge
14
commits into
RaspberryPiFoundation:project-cereal
from
BeksOmega:cereal/types
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bdb1073
Reformat registry tests
BeksOmega 3bfb194
Add tests for plugin hooks
BeksOmega 564dd16
Add plugin hooks for serialization
BeksOmega 8cd930e
Switch PluginSerializer to IPluginSerializer
BeksOmega 38a0825
fix: types
BeksOmega d09f48f
fix: PR comments
BeksOmega 2c46891
fix: tests
BeksOmega a9ccd2e
cleanup: formatting
BeksOmega 5dd498b
fix: types
BeksOmega fe5be03
feat: add respecting case in registry
BeksOmega 511982d
feat: add separate registry for serializers
BeksOmega 27f2a93
fix: Change type defs for state types to records
BeksOmega 20fab5f
fix: PR comments
BeksOmega a6d1ca4
fix: extraState type
BeksOmega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really think you need the
|undefinedsince*meansALLwhich includesundefined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, what you said makes sense so I removed it, but it gave me a compiler error. Maybe
|undefinedisn't required in general, but it is when specifying optional properties?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess that makes sense too.