Skip to content

Conversation

@BeksOmega
Copy link
Contributor

@BeksOmega BeksOmega commented Aug 27, 2021

The basics

  • I branched from project-cereal
  • My pull request is against project-cereal
  • My code follows the style guide

The details

Resolves

Work on project cereal

Proposed Changes

Fixes copying and pasting blocks that only contain JSO serialization hooks.

Reason for Changes

Copy paste should work for both systems.

Test Coverage

Manually tested off of the #5392 branch.

  • Copying and pasting a block with only new hooks.
  • Copying and pasting a block with only old hooks.
  • Copying and pasting a block with both sets of hooks.

@BeksOmega BeksOmega requested a review from a team as a code owner August 27, 2021 19:54
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Aug 27, 2021
@BeksOmega BeksOmega marked this pull request as draft August 30, 2021 14:22
@BeksOmega
Copy link
Contributor Author

I think it'll be easier to rewrite this rather than try to salvage it.

@BeksOmega BeksOmega closed this Sep 2, 2021
@BeksOmega BeksOmega deleted the cereal/copy-paste branch September 16, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by Google's CLA checker.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant