Move alert/confirm/prompt to a new file, dialog.js #5457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to core/dialog.js
| * @param {string} message The message to display to the user. | ||
| * @param {function()=} opt_callback The callback when the alert is dismissed. | ||
| */ | ||
| const alert = function(message, opt_callback) { |
Collaborator
There was a problem hiding this comment.
Why create a wrapper here, instead of just doing exports.alert = alertImplementation?
Contributor
Author
There was a problem hiding this comment.
Because that exports the initial value of alertImplementation, so even if alertImplementation gets modified via the setter, the initial/default implementation will continue to be used.
Collaborator
There was a problem hiding this comment.
Right, that makes sense.
The comment is no longer correct (for this and the others) because to override you would call setAlert rather than overriding alert.
Contributor
Author
There was a problem hiding this comment.
Updated the JSDoc to clarify, thanks!
rachel-fenichel
approved these changes
Sep 13, 2021
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Resolves
Part of #5208
Proposed Changes
This PR moves Blockly.alert/confirm/prompt into a new Blockly.dialog namespace in core/dialog.js. It also migrates uses in core to use Blockly.dialog.* instead of Blockly.*, and adds (deprecated) setters and getters under the old name in Blockly for backwards compatibility.