Skip to content

Conversation

@maribethb
Copy link
Contributor

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test.

The details

Resolves

Part of #5026 and #5208

Proposed Changes

Remove Blockly.onContextMenu_ from blockly.js

This function appears to be totally unused. It is private, so external developers should not be calling it. The functionality is already separately implemented in inject.js. Therefore, this function can just be removed and not moved or aliased.

Additional Information

Tested manually that right-clicking while focused on an html input still does not suppress the native context menu.

Also, this removes the dependency on Blockly.utils as the only other code depending on it is in Blockly.onKeyDown which is moved in #5476 . Therefore, that PR should be submitted first to keep the dependency graph correct.

@maribethb maribethb requested a review from a team as a code owner September 16, 2021 17:36
@maribethb maribethb requested a review from BeksOmega September 16, 2021 17:36
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 16, 2021
@maribethb maribethb requested a review from gonfunko September 16, 2021 17:36
@github-actions github-actions bot added this to the 2021_q3_release milestone Sep 16, 2021
@maribethb maribethb removed the request for review from BeksOmega September 16, 2021 17:36
@maribethb maribethb merged commit c5acc1d into RaspberryPiFoundation:goog_module Sep 16, 2021
@maribethb maribethb mentioned this pull request Sep 21, 2021
33 tasks
@maribethb maribethb deleted the module_oncontextmenu branch April 1, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by Google's CLA checker. type: cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants