refactor: remove unused Blockly.onContextMenu_ #5480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Resolves
Part of #5026 and #5208
Proposed Changes
Remove
Blockly.onContextMenu_from blockly.jsThis function appears to be totally unused. It is private, so external developers should not be calling it. The functionality is already separately implemented in inject.js. Therefore, this function can just be removed and not moved or aliased.
Additional Information
Tested manually that right-clicking while focused on an html input still does not suppress the native context menu.
Also, this removes the dependency on Blockly.utils as the only other code depending on it is in Blockly.onKeyDown which is moved in #5476 . Therefore, that PR should be submitted first to keep the dependency graph correct.