chore: move some properties to constants.js #5741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Moves two properties,
VARIABLE_CATEGORY_NAMEandPROCEDURE_CATEGORY_NAME, frominternal_constants.jstoconstants.js.Behavior Before Change
Names were only exported at the top level.
Behavior After Change
Names are exported in constants, which means that generators can use them by importing constants.
Reason for Changes
Needed to make generator migration (#5716) work, because it needs to use those two properties but not import all of Blockly.
Test Coverage
Standard tests
Documentation
No change
Additional Information
I updated the aliases for jsdoc.
I left
VARIABLE_DYNAMIC_CATEGORY_NAMEalone because I don't have an immediate need to access it.