fix: component id should be on the prototype #6104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Apr 22, 2022
| */ | ||
| class DragTarget { | ||
| /** | ||
| * Constructor for DragTarget. It exists to add the id property and should not |
Contributor
There was a problem hiding this comment.
If this isn't meant to be constructed directly, should it be tagged @abstract?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #5857
Proposed Changes
Changes the
idproperty oni_componentto be on the prototype, and then updates things that implementIComponentaccordingly.The IDs were already there--created in the constructors for things that implement
IComponent.idwas not supposed to be at the top level, since it's not shared between instances of a class.Also added
disposetoIBlockDragger.Reason for Changes
Fix type errors to convert to typescript