chore: rename all JS files to TS files #6297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
ts/rename-all-files
branch
from
d341efa to
13e829b
Compare
BeksOmega
changed the title
BeksOmega
requested review from
rachel-fenichel
and removed request for
cpcallen
maribethb
approved these changes
Aug 1, 2022
Contributor
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
maybe add a note that the tests will be fixed in the next PR for future / outside reference but lgtm
Contributor
Author
Done! |
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Sep 12, 2022
core/blockly.js was removed from the ts/migration branch in PR RaspberryPiFoundation#6261, but for some reason when ts/migration was merged into develop via a two step process something went wrong: * as expected, blockly.js got renamed to blockly.ts in PR RaspberryPiFoundation#6297, but * for some reason it got re-added under its original name in PR RaspberryPiFoundation#6299. Since the file should not exist, is not used, and has proven to cause confusion (to me at least!), delete it again, hopefully for good this time.
4 tasks
cpcallen
added a commit
that referenced
this pull request
Sep 14, 2022
core/blockly.js was removed from the ts/migration branch in PR #6261, but for some reason when ts/migration was merged into develop via a two step process something went wrong: * as expected, blockly.js got renamed to blockly.ts in PR #6297, but * for some reason it got re-added under its original name in PR #6299. Since the file should not exist, is not used, and has proven to cause confusion (to me at least!), delete it again, hopefully for good this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #5857
Proposed Changes
Changes the names of all of the files from .js to .ts
Behavior Before Change
No change in behavior.
Behavior After Change
No change in behavior
Reason for Changes
No change in behavior
Test Coverage
N/A
Documentation
I mean we probably have stuff that references
xthing.jsbut ¯\_(ツ)_/¯Additional Information
Cherry-pick of the first commit of ts/migration
Tests will be fixed by the next PR (#6242)