chore(build): Re-delete tests/run_all_tests.sh #6636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bash script tests/run_all_tests.js was deleted in PR RaspberryPiFoundation#6431, where it was replaced by `scripts/gulpfiles/test_tasks.js`, but it was inadvertently resurrected by PR RaspberryPiFoundation#6475, apparently due to an error when manually resolving conflicts for merge commit 00676ed. Begone, undead script!
cpcallen
added
component: build process
PR: chore
github-actions
bot
added
PR: chore
BeksOmega
approved these changes
Nov 18, 2022
Contributor
|
The title and description talk about deleting the .js file, when in fact it's the .sh file. |
cpcallen
changed the title
github-actions
bot
added
PR: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
The bash script
tests/run_all_tests.shwas deleted in PR #6431, where it was replaced byscripts/gulpfiles/test_tasks.js, but it was inadvertently resurrected by PR #6475, apparently due to an error when manually resolving conflicts for merge commit 00676ed.Proposed Changes
Delete it again.