fix: not being able to set field values to empty #6702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6701
Proposed Changes
Makes it so that you can set a text field to empty.
Reason for Changes
Sometimes the empty string is useful!
Test Coverage
Mostly manual testing. Also updated some change-detector tests to not fail. (gah past self)
Documentation
N/A
Additional Information
I think the issue started here: #6073
Basically, we used to be checking the text value against
nulland then we were checking it against''(to see if it had changed), which was failing.So now, instead of trying to do this weird thing to check if the value had changed, just let
setValuehandle it like a normal field, and setisDirty_in thedoValueUpdate_anddoValueInvalid_functions instead of forcing a layout "manually".