chore: delete old proc data code #6736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
chore/delete-old-proc-data-code
branch
from
5288cf1 to
ff27c7b
Compare
BeksOmega
force-pushed
the
chore/delete-old-proc-data-code
branch
from
ff27c7b to
3131dee
Compare
BeksOmega
force-pushed
the
chore/delete-old-proc-data-code
branch
from
18041b2 to
4a04693
Compare
4 tasks
BeksOmega
requested review from
gonfunko
and removed request for
rachel-fenichel
gonfunko
reviewed
Jan 9, 2023
gonfunko
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6526
Fixes #3725
Fixes #942
Proposed Changes
Finishes converting the procedure blocks to use the procedure data models by removing any code that relied on the old data storage properties.
Re #3725: Parameters now have a separate ID stored in the IParameterModel which callers can rely on.
Re #942: Instead of using a change listener, procedure defs are now created when the procedure caller looks up its model and can't find one.
Reason for Changes
Explicit data models are allow us to support sharing procedures between workspaces.
Test Coverage
Ran through all of the manual testing outlined in this doc: https://docs.google.com/document/d/1XsE6NOcfHyRZZ0eDtz6QfFg4KVPYqGVijm5ebRp6PJM/edit#
Documentation
N/A
Additional Information
Dependent on #6723