fix: proc json serialization #6746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/proc-json-serialization
branch
from
fbdc7d6 to
6bd64a3
Compare
4 tasks
BeksOmega
force-pushed
the
fix/proc-json-serialization
branch
2 times, most recently
from
4dacf8f to
d3a53d3
Compare
cpcallen
reviewed
Jan 11, 2023
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Procedure parameters were not being rendered correctly when loading from JSON. This fixes that.
Is there an issue for this? Or can you be a bit more specific about what was broken and how this fixes it?
Specifically, what I see is that:
- You've disabled events in one place.
- You've renamed one method name (seemingly @internal but not declared as such) to remove one of two trailing underscores.
- You've added tests.
Presumably adding tests did not itself fix the problem, so it would be useful to understand how either of the first two items might.
BeksOmega
force-pushed
the
fix/proc-json-serialization
branch
from
d3a53d3 to
2a916d7
Compare
Contributor
Author
|
The relevant change is the call to |
cpcallen
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
N/A
Proposed Changes
Procedure parameters were not being rendered correctly when loading from JSON. This fixes that.
Reason for Changes
Properly rendering parameters is important!
Test Coverage
Added JSON serialization tests equivalent to the existing XML serialization tests.
Documentation
N/A
Additional Information
Dependent on #6745