fix(tests): Use build/msg/en.js instead of msg/messages.js
#6825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change had already been made (by PR RaspberryPiFoundation#6475 amongst other) to most of the tests, but there were a couple of stragglers that still mentioned messages.js. Fixes RaspberryPiFoundation#6824.
maribethb
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6824.
Proposed Changes
Use
en.jsinstead ofmessages.jsin tests.Reason for Changes
messages.jsis not intended to be used this way. Also: we want to test build output.Additional Information
This change had already been made (by PR #6475 amongst other) to most of the tests, but there were a couple of stragglers that still mentioned
messages.js.