fix: prevent default undo #7946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/prevent-default-undo
branch
from
8c87dc6 to
9f0f51c
Compare
BeksOmega
force-pushed
the
fix/prevent-default-undo
branch
from
9f0f51c to
3e4c061
Compare
rachel-fenichel
approved these changes
Apr 2, 2024
Collaborator
rachel-fenichel
left a comment
rachel-fenichel
left a comment
There was a problem hiding this comment.
LGTM but please test well!
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
* fix: prevent default undo * chore: fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1915
Proposed Changes
Prevents default actions for events where we trigger undo or redo.
Test Coverage
Tested with my next PR, which relies on this behavior. (Undoing and redoing comment change events, which edit a text area)
Documentation
N/A
Additional Information
N/A